Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] USHIFT-3275: Retry virt-install command in case of installation error #3482

Merged
merged 2 commits into from
Jun 13, 2024
Merged

[release-4.16] USHIFT-3275: Retry virt-install command in case of installation error #3482

merged 2 commits into from
Jun 13, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3448

/assign ggiguash

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 13, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 13, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-3136

In response to this:

This is an automated cherry-pick of #3448

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and ggiguash June 13, 2024 08:30
@ggiguash
Copy link
Contributor

/test microshift-metal-tests

@ggiguash
Copy link
Contributor

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 13, 2024
@ggiguash
Copy link
Contributor

/cherrypick release-4.15

@openshift-cherrypick-robot
Copy link
Author

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor

ggiguash commented Jun 13, 2024 •
edited by openshift-ci bot
Loading

/retitle [release-4.16] USHIFT-3275: Retry virt-install command in case of installation error

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@openshift-ci openshift-ci bot changed the title [release-4.16] USHIFT-3136: Retry virt-install command in case of installation error [release-4.16] USHIFT-3275: Retry virt-install command in case of installation error Jun 13, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 13, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references USHIFT-3275 which is a valid jira issue.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

This is an automated cherry-pick of #3448

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 17a8dc8 into openshift:release-4.16 Jun 13, 2024
8 checks passed
@openshift-cherrypick-robot
Copy link
Author

@ggiguash: #3482 failed to apply on top of branch "release-4.15":

Applying: Retry virt-install command in case of installation error
Using index info to reconstruct a base tree...
M	test/bin/scenario.sh
Falling back to patching base and 3-way merge...
Auto-merging test/bin/scenario.sh
CONFLICT (content): Merge conflict in test/bin/scenario.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Retry virt-install command in case of installation error
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash ggiguash mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@ggiguash ggiguash Awaiting requested review from ggiguash

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @ggiguash